-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read_buf
uses in std
#125404
Fix read_buf
uses in std
#125404
Conversation
rustbot has assigned @workingjubilee. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Waiting to see how a bit more of the discussion plays out given #78485 (comment) |
It seems like there should be tests for this? |
Hm, not much comment since then... @a1phyr Can probably accept this with added tests that clarify the behavior we implement internally and the doc-comment on the Read trait that they mention. |
@rustbot author |
☔ The latest upstream changes (presumably #130710) made this pull request unmergeable. Please resolve the merge conflicts. |
50196d3
to
2b39f85
Compare
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
f578a8a
to
9bf69aa
Compare
9bf69aa
to
d77664b
Compare
So the primary effect of this PR is to guard against calls to |
Yes! |
Cool. @bors r+ rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125404 (Fix `read_buf` uses in `std`) - rust-lang#130866 (Allow instantiating object trait binder when upcasting) - rust-lang#130922 (Reference UNSPECIFIED instead of INADDR_ANY in join_multicast_v4) - rust-lang#130924 (Make clashing_extern_declarations considering generic args for ADT field) - rust-lang#130939 (rustdoc: update `ProcMacro` docs section on helper attributes) - rust-lang#130940 (Revert space-saving operations) - rust-lang#130944 (Allow instantiating trait object binder in ptr-to-ptr casts) - rust-lang#130953 (Rename a few tests to make tidy happier) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125404 - a1phyr:fix-read_buf-uses, r=workingjubilee Fix `read_buf` uses in `std` Following lib-team decision here: rust-lang#78485 (comment) Guard against the pathological behavior of both returning an error and performing a read.
Following lib-team decision here: #78485 (comment)
Guard against the pathological behavior of both returning an error and performing a read.